Experimenting with a more reliable graphical header layout?#276
Open
Experimenting with a more reliable graphical header layout?#276
Conversation
Contributor
|
Thanks for the comment on #275. Much better to use the current char/font-height than rely on my hard-coded values. I did wonder about that after I submitted my PR 🤷♂️ I think the changes in #276 generally work well. Couple of niggles:
I don't mind looking into the above. But equally happy if you want to continue. Screen.Recording.2026-02-09.at.17.39.17.mov |
Owner
Author
|
Yup. Feel free to take a look. Happy for you to take over the PR if you'd like. We may have to apply whatever we arrive to on both of our ends to get some coverage (we have slightly different setups). BTW, you may have noticed I have the same background color throughout, so it's good that you have a different header background color. |
Owner
Author
|
ps. There's also a text-based header if you'd like that as an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking into graphical header improvements for #275